Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Python 3.2 #251

Merged
merged 10 commits into from May 6, 2015
Merged

Remove support for Python 3.2 #251

merged 10 commits into from May 6, 2015

Conversation

ihamburglar
Copy link
Contributor

This PR removes Python 3.2 as @hynek requested in #241 due to cryptography's deprecation of it in pyca/cryptography#1846. I did some grepping to see if 3.2 was referenced in the docs(or elsewhere) but didn't see anything. Let me know if there are any other likely locations.

Only loosely related, is there any reason why we test against 3.4 in tox and travis but don't have it listed in setup.py? Oversight?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.31% when pulling e667f0a on elitest:deprecate32 into f3fc99e on pyca:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.31% when pulling e667f0a on elitest:deprecate32 into f3fc99e on pyca:master.

@hynek
Copy link
Contributor

hynek commented May 3, 2015

Thanks, I want to merge #247 first though. I wish there were way to express that in GitHub issues. :(

@hynek hynek added this to the 0.16 milestone May 3, 2015
@reaperhulk
Copy link
Member

This needs a rebase due to the fix in #253

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e8003f3 on elitest:deprecate32 into * on pyca:master*.

2015-05-02 Jim Shaver <dcypherd@gmail.com>

* .travis.yml, setup.py, tox.ini: Removed support for Python 3.2.
This version is rarely used and is now depricated by a major
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"deprecated"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye, I always have trouble with that word. cc265b2

@ihamburglar
Copy link
Contributor Author

My first rebase but I made it out the other side. Cheers

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ff6f4e5 on elitest:deprecate32 into * on pyca:master*.


* .travis.yml, setup.py, tox.ini: Removed support for Python 3.2.
This version is rarely used and is now deprecated by a major
dependency of pyOpenSSL(cryptography). Affected users should upgrade
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is complete bikeshedding but please add a space before (cryptography) and a second space before Affected. Thanks!

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 720b209 on elitest:deprecate32 into * on pyca:master*.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 720b209 on elitest:deprecate32 into * on pyca:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b862d51 on elitest:deprecate32 into * on pyca:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 76c20d1 on elitest:deprecate32 into * on pyca:master*.

2 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 76c20d1 on elitest:deprecate32 into * on pyca:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 76c20d1 on elitest:deprecate32 into * on pyca:master*.

hynek added a commit that referenced this pull request May 6, 2015
Remove support for Python 3.2
@hynek hynek merged commit 9ce4fd0 into pyca:master May 6, 2015
@hynek
Copy link
Contributor

hynek commented May 6, 2015

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants