New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECDHE support by @amluto #71
Conversation
Conflicts: .gitignore OpenSSL/test/test_ssl.py
It would be great if there were a clean way to enumerate them rather than just listing them like this, but I don't know of one.
…rves Different OpenSSL builds support different curves. Determine the supported curves at startup and expose the list.
Using NIDs is awkward and requires updating pyOpenSSL every time a new curve is added. This approach avoids needing to update pyOpenSSL each time a new curve is added, and it results in more readable code and a more readable dict ELLIPTIC_CURVE_DESCRIPTIONS.
that we access them by name.
Here is a server using Twisted 13.2 + cryptography trunk + above pyOpenSSL with @amluto 's ECDH stuff : https://www.ssllabs.com/ssltest/analyze.html?d=demo.crossbar.io |
@lvh tests are all green, but builds fail (due to "old" cryptography). Does that mean "good"? |
That means "good" once cryptography makes a release, we depend on that release, we update master, and we re-merge master into this branch. pyopenssl master builds always have to be all green :) |
@lvh Alright, understood. @reaperhulk just confirmed there is an upcoming 0.3 "next week or so". Thanks! |
Thanks. As far as I can tell, github makes it a real pain to have two pull requests open for one branch (I know your branch and amluto's branch aren't actually the same branch but for most practical purposes they are). I'm going to close this and focus on amluto's PR. Please follow-up there. |
No description provided.