Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all Time Series Notebooks #3388

Merged
merged 3 commits into from
Mar 12, 2023
Merged

Fix all Time Series Notebooks #3388

merged 3 commits into from
Mar 12, 2023

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Mar 11, 2023

Related Issue or bug

Fixes time series notebooks (content to match latest features + running on GitHub CI)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

GitHub CI to pass

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 marked this pull request as ready for review March 11, 2023 15:49
@ngupta23 ngupta23 changed the title Fix all TS notebooks Fix all Time Series Notebooks Mar 11, 2023
@ngupta23 ngupta23 requested review from moezali1 and Yard1 March 11, 2023 15:53
@ngupta23 ngupta23 added this to the pycaret 3.0.0 milestone Mar 11, 2023
@ngupta23 ngupta23 added documentation Improvements or additions to documentation time_series Topics related to the time series labels Mar 11, 2023
@ngupta23 ngupta23 requested a review from tvdboom March 12, 2023 01:35
@ngupta23 ngupta23 merged commit 127ac76 into master Mar 12, 2023
@ngupta23 ngupta23 deleted the fix_ts_notebooks branch March 12, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation time_series Topics related to the time series
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants