Dependencies: Permit NumPy up to 1.26. CI: Run Python 3.11 on test_linux workflow.
#3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
commented
Nov 5, 2023
| numpy>=1.21, <1.24 # Can't >=1.24 because of np.float deprecation | ||
| numpy>=1.21, <1.27 |
There was a problem hiding this comment.
We can't see where the code base uses np.float. Only np.float32 and np.float64 have been discovered so far. So, we think it will be good enough to unlock a few modernization opportunities.
|
Hi, thanks for the PR! Let's see if the CI passes. |
|
It looks good so far, but test_windows (3.10) apparently failed again after 14 minutes spending within the "Post Run" actions cleanup task, in the very same way as Python 3.8 on our workflow run 1.
It may indirectly be related to the change, but I am unable to come up with a good correlation why, so I am tending to classify it as "unrelated". What do you think? Footnotes |
Yard1
approved these changes
Nov 5, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again,
in order to support GH-3756, this patch demonstrates that running the test suite succeeds on Python 3.11 without much ado, by permitting an installation of a more recent version of NumPy. This will probably also open the door for eventually thinking about upgrading pandas.
We exercised it at 1 already, where Python 3.11/Linux succeeded, and we think the test suite failing on Windows 3.8 might be unrelated. Maybe you can have a closer look?
With kind regards,
Andreas.
Footnotes
https://github.com/crate-workbench/pycaret/actions/runs/6762683108 ↩