Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SymPy version 1.9 #138

Merged
merged 18 commits into from Jul 18, 2023
Merged

Use SymPy version 1.9 #138

merged 18 commits into from Jul 18, 2023

Conversation

tomcaruso
Copy link
Contributor

@tomcaruso tomcaruso commented Jul 14, 2023 •
edited by yguclu

  • Adapt SymPDE for working with new versions of SymPy (up to 1.9)
  • Increase minimum required version of SymPy from 1.2 to 1.5
  • Change SymPDE library version to 0.18.0

For now, SymPy 1.10 is not supported yet.

@tomcaruso tomcaruso marked this pull request as draft July 14, 2023 13:24
@yguclu yguclu changed the title Upgrade sympy Use new version of SymPy Jul 17, 2023
@yguclu yguclu marked this pull request as ready for review July 18, 2023 14:55
@yguclu yguclu changed the title Use new version of SymPy Use SymPy version 1.9 Jul 18, 2023
@yguclu
Update pyproject.toml
8d997e9 
Require SymPy minimum version 1.5
@yguclu
Update core.py
7befa4e 
Correct empty lines in imports
@yguclu
Update algebra.py
e18a430 
Correct empty lines in imports
@yguclu
Update expr.py
e4c69c7 
Correct empty lines in imports
@yguclu
Update datatype.py
c5e7124 
Correct empty lines in imports
@yguclu
Update domain.py
f384b4a 
Correct empty lines in imports
yguclu
yguclu approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@yguclu yguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job @tomcaruso!

@yguclu yguclu merged commit 3dec079 into master Jul 18, 2023
5 checks passed
@yguclu yguclu deleted the Upgrade_sympy branch July 18, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yguclu yguclu yguclu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomcaruso @yguclu