Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basic auth broken in jirashell #66

Closed
fastcat opened this issue Apr 29, 2015 · 1 comment
Closed

basic auth broken in jirashell #66

fastcat opened this issue Apr 29, 2015 · 1 comment

Comments

@fastcat
Copy link
Contributor

fastcat commented Apr 29, 2015 

        if oauth:
            self._create_oauth_session(oauth)
        elif basic_auth:

oauth is never None because jirashell.process_config always creates an object, which means that the basic_auth section is now unreachable, as the else section after it.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@fastcat
Copy link
Contributor Author

fastcat commented Apr 30, 2015

Created pull #67 to fix this, but my github fu to auto-link the two failed

@milo-minderbinder milo-minderbinder mentioned this issue Jul 14, 2015
Closed
milo-minderbinder added a commit to milo-minderbinder/jira that referenced this issue Jul 15, 2015
@milo-minderbinder
Minor fixes to jirashell issues pycontribs#100, pycontribs#102, and p…
a55dc88 
…ycontribs#66, and tweaks fix from d585674. The oauth_dance and print_tokens options specified in jirashell.ini configuration file are now correctly parsed as boolean values and OAuth with pre-authenticated access_token and access_token_secret (skipping oauth_dance) is fixed. OAuth options are now minimally validated for completeness, so pycontribs#66 is fixed, allowing for basic_auth without causing issue pycontribs#102 as the merged commit d585674 did previously.
@milo-minderbinder milo-minderbinder mentioned this issue Jul 15, 2015
Merged
ssbarnea added a commit that referenced this issue Aug 4, 2015
@ssbarnea
Merge pull request #103 from milo-minderbinder/master
4040372 
Minor jirashell fixes - #100, #102, #66, and tweaks for d585674
@ssbarnea ssbarnea closed this as completed May 1, 2016
ssbarnea added a commit that referenced this issue Nov 21, 2016
@ssbarnea
Merged in simonventuri/jira-python/yosemite-six-fix (pull request #66)
acc65c2 
Fix html_parser import from six.moves.
ssbarnea pushed a commit that referenced this issue Nov 21, 2016
@milo-minderbinder
Minor fixes to jirashell issues #100, #102, and #66, and tweaks fix f…
1425bb8 
…rom d585674. The oauth_dance and print_tokens options specified in jirashell.ini configuration file are now correctly parsed as boolean values and OAuth with pre-authenticated access_token and access_token_secret (skipping oauth_dance) is fixed. OAuth options are now minimally validated for completeness, so #66 is fixed, allowing for basic_auth without causing issue #102 as the merged commit d585674 did previously.
ssbarnea added a commit that referenced this issue Nov 21, 2016
@ssbarnea
Merge pull request #103 from milo-minderbinder/master
d32d50b 
Minor jirashell fixes - #100, #102, #66, and tweaks for d585674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ssbarnea @fastcat