Minor jirashell fixes - #100, #102, #66, and tweaks for d5856742771890ad18165197f6bc7eb3ff8cd086 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that 'oauth_dance' should be an optional option argument, if it is not set, or if it is set to false, a valid use case still exists where OAuth should be used if the user supplies access_token and access_token_secret through command line or configuration file options. This would be the case if the user had already authenticated externally with OAuth and had valid, authenticated tokens to pass to jirashell. Commit d585674 doesn't fix the issue anyway, since configuration file options are all read by value, and interpreted as strings, but, presumably, oauth_dance should be a boolean option. The result is that "if oauth['oauth_dance']:" will always be True, if oauth_dance is set to anything (including False) in the configuration file.
Conflicts: release.sh
…ycontribs#66, and tweaks fix from d585674. The oauth_dance and print_tokens options specified in jirashell.ini configuration file are now correctly parsed as boolean values and OAuth with pre-authenticated access_token and access_token_secret (skipping oauth_dance) is fixed. OAuth options are now minimally validated for completeness, so pycontribs#66 is fixed, allowing for basic_auth without causing issue pycontribs#102 as the merged commit d585674 did previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixes for jirashell issues #100, #102, and #66, and tweaks fix from d585674. The
oauth_danceandprint_tokensoptions specified in jirashell.ini configuration file are now correctly parsed as boolean values and OAuth with pre-authenticatedaccess_tokenandaccess_token_secret(skippingoauth_dance()) is fixed. OAuth options are now minimally validated for completeness, so #66 is fixed, allowing for basic auth without causing issue #102 as the merged commit d585674 did previously.