jirashell: boolean options incorrectly parsed as strings from configuration file #102
Comments
milo-minderbinder
added a commit
to milo-minderbinder/jira
that referenced
this issue
Jul 15, 2015
…ycontribs#66, and tweaks fix from d585674. The oauth_dance and print_tokens options specified in jirashell.ini configuration file are now correctly parsed as boolean values and OAuth with pre-authenticated access_token and access_token_secret (skipping oauth_dance) is fixed. OAuth options are now minimally validated for completeness, so pycontribs#66 is fixed, allowing for basic_auth without causing issue pycontribs#102 as the merged commit d585674 did previously.
ssbarnea
pushed a commit
that referenced
this issue
Nov 21, 2016
…rom d585674. The oauth_dance and print_tokens options specified in jirashell.ini configuration file are now correctly parsed as boolean values and OAuth with pre-authenticated access_token and access_token_secret (skipping oauth_dance) is fixed. OAuth options are now minimally validated for completeness, so #66 is fixed, allowing for basic_auth without causing issue #102 as the merged commit d585674 did previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Options read from the jirashell.ini configuration from the [oauth] section are all (incorrectly) treated as strings. This causes the the
if 'oauth_dance' in oauth and oauth['oauth_dance']:statement in the main method to incorrectly evaluate to True whenever 'oauth_dance' is set in the jirashell.ini, even if it is set to False.The text was updated successfully, but these errors were encountered: