Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pep8 #91

Closed
asottile opened this issue Apr 3, 2021 · 5 comments
Closed

Update pep8 #91

asottile opened this issue Apr 3, 2021 · 5 comments

Comments

@asottile
Copy link
Member

asottile commented Apr 3, 2021

In GitLab by @rfleschenberg on Mar 25, 2015, 07:10

The pep8 tool that comes bundled with flake8 is outdated and reports false warnings. You should update.

E.g.:

# foo.py
a = 1
b = 2
print a*b + b*b

flake8 foo.py
foo.py:4:8: E225 missing whitespace around operator
foo.py:4:14: E225 missing whitespace around operator
@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @sigmavirus24 on Mar 25, 2015, 09:50

Please check existing (closed and open) issues before filing new ones. We're specifically pinning to <1.6.0 because it breaks other features. If you want to use newer (broken) versions of pep8, pin to flake8 2.3.0

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @rfleschenberg on Mar 26, 2015, 02:54

I searched the existing issues, but could not find a related one. Can you point me to it?

So, you're "specifically pinning to" what? A certain pep8 version, I suppose? I realize that. The point is that the pep8 version you are using is buggy. It contradicts PEP 8.
See the output I gave above vs. https://www.python.org/dev/peps/pep-0008/#other-recommendations

You should either update your pep8 version or backport the fix for this bug.

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @rfleschenberg on Mar 26, 2015, 02:59

OK. Now I read a little more on the other issues and realize how they are related. Sorry. I was also thinking you had actually bundled pep8, but it seems I was looking at the wrong source? Anyway, closing. I hope this gets fixed soon.

@asottile asottile closed this as completed Apr 3, 2021
@rfleschenberg
Copy link

@asottile Thanks! @sigmavirus24, I want to apologize for my comments. Reading them again now after 6 years have passed, I realize I sounded like an entitled asshole :( Sorry.

@sigmavirus24
Copy link
Member

Appreciate it @rfleschenberg

We all have bad moments. I've definitely had mine and I'm trying to avoid having more by trying to figure out my stress coping strategies right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants