Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pypi release is missing test_mccabe.py #31

Closed
tamentis opened this issue Feb 24, 2015 · 6 comments
Closed

Pypi release is missing test_mccabe.py #31

tamentis opened this issue Feb 24, 2015 · 6 comments
Milestone

Comments

@tamentis
Copy link

I was updating a port of mccabe and noticed that test_mccabe.py was missing from the Pypi release.

@sigmavirus24
Copy link
Member

@tamentis it has never shipped with a release.

@tamentis
Copy link
Author

Yup, I can see that. The change log mentions the added tests for 0.3 so I was planning on adding that as part of the port in OpenBSD. For most Python ports, the test suite runs but I guess we'll skip it for mccabe 0.3.

@sigmavirus24
Copy link
Member

You can still pull it in, I just don't see much value in including it in the PyPI package. Is it really necessary the the tests be included in the package itself?

@tamentis
Copy link
Author

You're right, I can pull it in and test it locally.

Adding test suites to official releases means they are likely to be run as part of the packaging systems and will be executed on thousands of machine, on various architectures and operating systems and could find bugs in places authors never imagined :)

However mccabe doesn't have dependencies, its test suite is tiny and new, so it doesn't matter as much. If I really wanted it, I could just base the port from the github tag, but I'll just skip the test suite for the OpenBSD package.

aszlig added a commit to NixOS/nixpkgs that referenced this issue Apr 12, 2015
Regression introduced by 56a6f22.

I'm temporarily pulling in test_mccabe.py, as suggested by someone at
PyCQA/mccabe#31, which for now should fix the build (and the tests
of course as well).

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Lindstroem pushed a commit to Lindstroem/nixpkgs that referenced this issue Apr 16, 2015
Regression introduced by 56a6f22.

I'm temporarily pulling in test_mccabe.py, as suggested by someone at
PyCQA/mccabe#31, which for now should fix the build (and the tests
of course as well).

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
@floppym
Copy link

floppym commented Apr 21, 2015

Speaking as a Linux distro maintainer, we would prefer that you include the tests in the pypi tarball so that we don't have to piece together sources from multiple locations. The extra bytes won't hurt anyone.

@sigmavirus24 sigmavirus24 modified the milestone: 0.3.1 Jun 13, 2015
@sigmavirus24
Copy link
Member

Fixed by eb9df5f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants