Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Finance url is still incorrect in PyPI #426

Closed
bsolomon1124 opened this issue Dec 5, 2017 · 1 comment
Closed

Google Finance url is still incorrect in PyPI #426

bsolomon1124 opened this issue Dec 5, 2017 · 1 comment

Comments

@bsolomon1124
Copy link

bsolomon1124 commented Dec 5, 2017

As noted in other issues & PR's here, the Google Finance API recently changed from google.com/finance/historical to finance.google.com/historical.

The url in the GitHub repo seems to be correct.

However, when I test, I'm still seeing the old url:

>>> import pandas_datareader as pdr
>>> test = pdr.google.daily.GoogleDailyReader('')
>>> print(test.url)
http://www.google.com/finance/historical

I'm using pdr.__version__ == 0.5.0, and have uninstalled and reinstalled (through conda-forge, if that matters), but am still seeing the same ambiguity.

Upon deeper look, the source of this is that the GitHub repo has the correct url, but the PyPI tar.gz download does not..

@davidastephens
Copy link
Member

Yes, we need a new release per #420. Will try to get as much working as we can then release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants