-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERF: Series.dropna with non-nan dtype blocks #11159
Conversation
8a3984a
to
9df129a
Compare
self.s = Series(np.random.randint(1, 10, 1000000)) | ||
|
||
def series_dropna_int64(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the function that actually get times should start with 'time'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this dropna
only has effect for each time setup
is run, which is not every iteration
And set seed (not sure)?
sure, pls add a note in 0.17.1 whatsnew |
@sinhrks looks good, can you rebase / add a release note |
Rebased, and added release note. Followings are asv results added in this PR.
|
PERF: Series.dropna with non-nan dtype blocks
thanks! |
Minor improvement when
dropna
actually does nothing. If OK for 0.17, I'll add a release note.