Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/anchor all elements #283

Merged
merged 5 commits into from
Nov 18, 2020

Conversation

hoetmaaiers
Copy link
Collaborator

Update to match all anchor elements with :target talked about in #280 .

@choldgraf
Copy link
Collaborator

very cool, I didn't know about this target selector, is it consistent across browsers?

@hoetmaaiers
Copy link
Collaborator Author

Supprisingly yes. I also learned about it thanks to @jorisvandenbossche 's research.

https://developer.mozilla.org/en-US/docs/Web/CSS/:target

@jorisvandenbossche
Copy link
Member

Cool!

@hoetmaaiers it seems you have a conflict (because the actual dt change is not in master, so the diff should show that this is removed or updated.

The change from 80 to 60px offset is intentional? (it looks fine on the demo docs for this PR)

@hoetmaaiers
Copy link
Collaborator Author

The merge conflicts are resolved now.

The choice for 60px is indeed on purpose. This leave some extra white space at the top without the anchor element being smacked to the edge.

@hoetmaaiers
Copy link
Collaborator Author

Grmbl, the merge resolution made the 'lint' check fail. @choldgraf or @jorisvandenbossche I always struggle with this check. Is it a problem with indentation or alike?

@jorisvandenbossche
Copy link
Member

@hoetmaaiers the issue was that yarn build:production was still producing a change, and particularly the removal of the old built css/js files.
(after doing a yarn build, you need to do git add pydata_sphinx_theme/static/ to ensure the deleted files are also tracked as deleted by git)

@choldgraf
Copy link
Collaborator

this LGTM! and the tests are now passing with @jorisvandenbossche 's fix 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants