-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert style changes #459
revert style changes #459
Conversation
Some of the changes don't seem to come from #451: Stable: <dt id="numpy.linalg.eig">
<code class="sig-prename descclassname"><span class="pre">numpy.linalg.</span></code><code class="sig-name descname"><span class="pre">eig</span></code><span class="sig-paren">(</span><em class="sig-param"><span class="n"><span class="pre">a</span></span></em><span class="sig-paren">)</span><a class="headerlink" href="#numpy.linalg.eig" title="Permalink to this definition">¶</a></dt> Latest: <dt class="sig sig-object py" id="numpy.linalg.eig">
<span class="sig-prename descclassname"><span class="pre">numpy.linalg.</span></span><span class="sig-name descname"><span class="pre">eig</span></span><span class="sig-paren">(</span><em class="sig-param"><span class="n"><span class="pre">a</span></span></em><span class="sig-paren">)</span><a class="headerlink" href="#numpy.linalg.eig" title="Permalink to this definition">¶</a></dt> Note how the CSS classes are different and even some I propose to consider this out of scope of the CSS fixes (this PR) and investigate separately—must be something on sphinx side. |
If this looks OK, I propose to merge as is, and open a separate issue for investigating why the classes and tags of the autodoc changed (it's likely sphinx/autodoc/... version change). |
Hmm - maybe those are from the latest release of Sphinx. If you downgrade to sphinx 3 do they revert as well? |
Could you open that issue? I know it wasn't your PR that caused it but I'm on mobile right now! |
I confirm: the autodoc title looks exactly the same as in stable branch if I downgrade to sphinx 3.5. Not sure how this should be addressed in the theme though. |
I opened #460 |
LGTM - thanks for following up on this! Merging so that we can get these fixes in |
@akhmerov thanks for the quick follow-up here! |
Closes #452
[hidden]
.dd
style from basic. This also fixes the autodoc indentation parts. Here, I think we're running into a problem of combining scss for theme asset compilation together with css inheritance. It may be more appropriate to vendor the entire ofbasic.css
into the build chain.