-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add ability to specify custom icon images #542
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
force-pushed
the
ENH-custom-icons
branch
2 times, most recently
from
January 8, 2022 00:50
cd05d6c
to
169c417
Compare
choldgraf
force-pushed
the
ENH-custom-icons
branch
from
January 8, 2022 01:01
169c417
to
a8f4fd4
Compare
damianavila
reviewed
Jan 10, 2022
damianavila
reviewed
Jan 10, 2022
damianavila
reviewed
Jan 10, 2022
damianavila
reviewed
Jan 10, 2022
Co-authored-by: Damian Avila <damianavila82@yahoo.com.ar>
damianavila
reviewed
Jan 10, 2022
damianavila
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comment/suggestions that you already incorporated, so LGTM!
choldgraf
changed the title
Add ability to specify custom icon images
END: Add ability to specify custom icon images
Jan 10, 2022
great! thanks :-) |
Nice feature, thanks! |
jorisvandenbossche
changed the title
END: Add ability to specify custom icon images
ENH: Add ability to specify custom icon images
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the ability for people to specify local images for their icon links, instead of only allowing fontawesome icons. Here are the major changes:
type
field for icon link config. The allowed values aretype: "fontawesome"
andtype: "local"
.fontawesome
is the default, so if people don't specify type, it'll default to the current behavior.type: "local"
and then supportsicon: path/to/img.png
, which will resolve to animg
element instead of aspan
.Here's how it looks in our demo docs:
Rationale
My rationale for adding this is that projects may want to link out to a "parent site" with this theme. For example, the JupyterHub docs might want to link up to jupyter.org. In that case, we could use an icon link with the Jupyter logo, rather than using extra screen real estate by putting
jupyter.org
in the navbar links.