Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CachingFileManager should not use __del__ #4267

Open
shoyer opened this issue Jul 25, 2020 · 2 comments
Open

CachingFileManager should not use __del__ #4267

shoyer opened this issue Jul 25, 2020 · 2 comments

Comments

@shoyer
Copy link
Member

shoyer commented Jul 25, 2020

__del__ is sometimes called after modules have been deallocated, which results in errors printed to stderr when Python exits. This manifests itself in the following bug:
h5netcdf/h5netcdf#50

Per h5netcdf/h5netcdf#50 (comment), the right solution is probably to use weakref.finalize.

@stale
Copy link

stale bot commented Apr 17, 2022

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

@stale stale bot added the stale label Apr 17, 2022
@shoyer
Copy link
Member Author

shoyer commented Apr 17, 2022

This is still relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant