Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document, annotate, and comment task.py #74

Open
martinruefenacht opened this issue Sep 24, 2020 · 3 comments
Open

Document, annotate, and comment task.py #74

martinruefenacht opened this issue Sep 24, 2020 · 3 comments

Comments

@martinruefenacht
Copy link

Hi, I'd like to contribute to the project by making it pep8 compliant and generally adding annotations, documentation, and comments.

Which version of Python is targeted by the code?

Given there are annotations in the code I assume at least Python 3.5.

@rp-
Copy link
Collaborator

rp- commented Sep 24, 2020

Hi!

It is stated in the setup.py file, minimum version is currently 3.6

@martinruefenacht
Copy link
Author

@rp- Ah! Thanks I missed that...

Are you okay with using Black as a formatter?
I typically think its a pretty good standard.

I'll start out with a single file to process and make a PR, so we can decide what style we want to use.

I'll also rename this issue to change it to something describing what I am doing.

@martinruefenacht martinruefenacht changed the title Target version of Python Document, annotate, and comment task.py Sep 25, 2020
@rp-
Copy link
Collaborator

rp- commented Sep 26, 2020

I usually try to keep the formatting from pycharm, but I think this is pep8, except for the generated files.
And I don't think it is worth to generate them full pep8 compatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants