Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the solve step if the mass matrix is identity or it is not provided #14

Closed
moorepants opened this issue Apr 10, 2014 · 2 comments
Closed

Comments

@moorepants
Copy link
Member

Issue by moorepants from Wednesday Feb 12, 2014 at 22:57 GMT
Originally opened as https://github.com/pydy/pydy-code-gen/issues/21


Right now the numpy.linalg.solve step is a slow down for any of these methods.

If the user solves the for M^-1 * F analytically then we don't need that. This can speed up things right now.

Later on we need to push the solve step to a low level in the generators so there is no python overhead. I'm not sure that the full mass matrix and forcing vector need to be used like this either, especially when the q dots equal the u's, then there is no reason to solve the full system. Finally, we need to do some learning and thinking about the Jain method in which you supposedly don't even have to form the mass matrix and do this solver.

tarzzz added a commit that referenced this issue Apr 12, 2014
@moorepants
Copy link
Member Author

Addressed in PR #113.

@jcrist
Copy link
Member

jcrist commented Mar 16, 2015

closed by #113

@jcrist jcrist closed this as completed Mar 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants