Shape dimensions should only be int or float

[yashu-seth]

>>> from pydy.viz.shapes import Sphere,Cube
>>> c = Cube('abcd')
>>> s = Sphere('xyz')
>>> print(s)
Sphere unnamed color:grey material:default radius:xyz
>>> print(c)
Cube unnamed color:grey material:default length:abcd

[yashu-seth]

@moorepants I don't think this behavior should be allowed. If you also feel the same, I can send a PR.

[moorepants]

We work somewhat on the "garbage in/garbage out" principal instead of having tons of type checks, but if you'd like to submit a PR with the type checks I will accept it. Thanks.

[yashu-seth]

@moorepants okay i think i'll pass. Can you please help me get started with some beginner friendly issues?

[moorepants]

This would be a good one to start with: #296

You have to run the examples and see which ones are using deprecated code.

[yashu-seth]

@moorepants thank you. I'll look into it.

[oliverlee]

I think the existing PR fixes this but I can't check for a while.
On Dec 17, 2015 15:55, "Yashu Seth" notifications@github.com wrote:

@moorepants https://github.com/moorepants thank you. I'll look into it.

—
Reply to this email directly or view it on GitHub
#299 (comment).

[yashu-seth]

@oliverlee yes, I think you have already sent a PR for this.

[oliverlee]

@yashu-seth I just realized I won't have wifi for a while. so if you'd like to work on it, please do. You can take a look at the existing PR for a starting point.

[moorepants]

Note that the shapes support sympy expressions as dimensions, so they shouldn't "only be int or float".

I actually don't see any reason to make these specific type checks. Python code typically follows duck typing and I'm fine if we use the garbage in/garbage out philosophy here. You simply need to have clear docstrings that say what should be passed in. We don't have to have tons of type checks.