Prefer OpenSSL 1.1 only for specific python versions #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is brilliant. Looks great. Thanks so much for following up on this. Very happy with these changes. Much love for you and your project @yyuu The fact that it's now toggled per-python version is ideal, really. Thanks for merging the previous PR even though it was imperfect.. and then making it more perfect. :D |
…inst versions w/ OpenSSL 1.1 support backported See also: * https://bugs.python.org/issue32947
This was referenced Apr 8, 2019
toslunar
added a commit
to toslunar/chainer
that referenced
this pull request
Jul 22, 2019
This reverts commit d4051e9, reversing changes made to 56cdf0e. pyenv/pyenv#1328 has fixed the issue.
nijave
added a commit
to nijave/borg
that referenced
this pull request
Apr 26, 2020
Docs aren't great but looks like you can specify a homebrew formula to use. If you don't, it looks like python-build ends up trying to use 1.1 https://github.com/pyenv/pyenv/blob/b1381d1d4630c5fb73517b78d68939663635311f/plugins/python-build/bin/python-build#L1512 pyenv/pyenv#1328
nijave
added a commit
to nijave/borg
that referenced
this pull request
Apr 26, 2020
Homebrew formula python-build option Docs aren't great but looks like you can specify a homebrew formula to use. If you don't, it looks like python-build ends up trying to use 1.1 https://github.com/pyenv/pyenv/blob/b1381d1d4630c5fb73517b78d68939663635311f/plugins/python-build/bin/python-build#L1512 pyenv/pyenv#1328
nijave
added a commit
to nijave/borg
that referenced
this pull request
Apr 26, 2020
Homebrew formula python-build option Docs aren't great but looks like you can specify a homebrew formula to use. If you don't, it looks like python-build ends up trying to use 1.1 https://github.com/pyenv/pyenv/blob/b1381d1d4630c5fb73517b78d68939663635311f/plugins/python-build/bin/python-build#L1512 pyenv/pyenv#1328
ThomasWaldmann
pushed a commit
to borgbackup/borg
that referenced
this pull request
Jun 1, 2020
use rbenv openssl 1.0 so it doesn't use openssl 1.1. Homebrew formula python-build option Docs aren't great but looks like you can specify a homebrew formula to use. If you don't, it looks like python-build ends up trying to use 1.1. https://github.com/pyenv/pyenv/blob/b1381d1d4630c5fb73517b78d68939663635311f/plugins/python-build/bin/python-build#L1512 pyenv/pyenv#1328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Prerequisite
Description
In #1302, I've merged a PR that lets
python-buildto always prefer Homebrew'sopenssl@1.1overopenssl(=== OpenSSL 1.0). However, in fact, some of older python versions don't support OpenSSL 1.1 and it caused some build failures.I ended up to tweak build definitions to add new parameter
prefer_openssl11to enable OpenSSL 1.1 only for some definitions.Tests
cc: @ThomasWaldmann @cculianu