Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fighters #18

Closed
DarkFenX opened this issue Oct 18, 2016 · 4 comments
Closed

Fighters #18

DarkFenX opened this issue Oct 18, 2016 · 4 comments

Comments

@DarkFenX
Copy link
Member

Posted by @Ebag333

Slots for fighters don't seem to exist at all in Eos.

We could treat them as drones, but that might get a bit complicated as fighters have multiple fighters per flight (example: 4 out of a maximum of 9), while drones are always a 1/1 ratio.

It's probably best to add a new spot for them.

fit.fighter.add(Fighter(2948, state=State.active, count=4))

An example fighter from the JSON:

  "2948": {
    "descriptionID": 93600, 
    "typeID": 2948, 
    "graphicID": 10039, 
    "capacity": 0.0, 
    "description": "<font color=yellow>Subject:</font> Prototype Nation Vessel (ID:Shadow)<br>\r\n<font color=yellow>Military Specifications:</font> Heavy Fighter class vessel. Moderate microwarp velocity. Enhanced weapons systems. Reverse-engineering has been made possible through salvage of specific Sansha's Nation vessels.<br>\r\n<font color=yellow>Additional Intelligence:</font> At this initial stage conclusions are hard to form, but early indications from the recovery of three individual bomber pilots – all of them heavily augmented – strongly indicates that these crew members are the same planetary abductees found in other Nation prototype vessels. Cross-referencing recovered DNA with missing persons reports has so far revealed little, though even at this stage the origin of these pilots is in little doubt.<br>\r\n<i>Synopsis from ISHAEKA-0107. DED Special Operations.</i><br><i>Authorized for Capsuleer dissemination.</i>   \r\n", 
    "typeNameID": 105075, 
    "published": true, 
    "marketGroupID": 1310, 
    "volume": 1800, 
    "typeName": "Shadow", 
    "radius": 35, 
    "basePrice": 20336332, 
    "mass": 2000, 
    "groupID": 1653, 
    "portionSize": 1
  }, 
@DarkFenX
Copy link
Member Author

Posted by @blitzmann

Yeah, fighters are a new thing and EOS was never updated for them AFAIK. While implementing them, we should consider adding the data that is also found here:

https://gist.github.com/blitzmann/935c2d5b178d62205ba88a30463e8eda

I would assume EOS should handle fighters and their abilities, along with DPS calcs and whatnot. This is something that I would really like @DarkFenX to look at and give opinion of..

@DarkFenX
Copy link
Member Author

Posted by @Ebag333

While implementing them, we should consider adding the data that is also found here

So we want to support multiple languages?

It'd actually be pretty trivial to add support for that, at least for the stuff that CCP has already translated for us.

Also, dang it, I forgot about their special abilities.

We could do something like:

fit.fighter.add(Fighter(2948, state=State.active, count=4, ability1=active, ability2=offline))

But that could get fugly if CCP ever added fighters with more than 3 abilities....

@DarkFenX
Copy link
Member Author

Posted by @blitzmann

So we want to support multiple languages?

No (well yes, but that's a different discussion), I was specifically referring to this data. https://gist.github.com/blitzmann/935c2d5b178d62205ba88a30463e8eda#file-fighterabilitiesbytype-json

It's currently hardcoded in pyfa which is less than ideal because I never got around to building out proper support for it.

@DarkFenX
Copy link
Member Author

DarkFenX commented May 1, 2018

Supported as of today

@DarkFenX DarkFenX closed this as completed May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@DarkFenX and others