-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fighters #18
Comments
Posted by @blitzmann Yeah, fighters are a new thing and EOS was never updated for them AFAIK. While implementing them, we should consider adding the data that is also found here: https://gist.github.com/blitzmann/935c2d5b178d62205ba88a30463e8eda I would assume EOS should handle fighters and their abilities, along with DPS calcs and whatnot. This is something that I would really like @DarkFenX to look at and give opinion of.. |
Posted by @Ebag333
So we want to support multiple languages? It'd actually be pretty trivial to add support for that, at least for the stuff that CCP has already translated for us. Also, dang it, I forgot about their special abilities. We could do something like:
But that could get fugly if CCP ever added fighters with more than 3 abilities.... |
Posted by @blitzmann
No (well yes, but that's a different discussion), I was specifically referring to this data. https://gist.github.com/blitzmann/935c2d5b178d62205ba88a30463e8eda#file-fighterabilitiesbytype-json It's currently hardcoded in pyfa which is less than ideal because I never got around to building out proper support for it. |
Supported as of today |
Posted by @Ebag333
Slots for fighters don't seem to exist at all in Eos.
We could treat them as drones, but that might get a bit complicated as fighters have multiple fighters per flight (example: 4 out of a maximum of 9), while drones are always a 1/1 ratio.
It's probably best to add a new spot for them.
An example fighter from the JSON:
The text was updated successfully, but these errors were encountered: