Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inversion operator(s) #5

Open
FredLunnon opened this issue Sep 16, 2016 · 5 comments
Open

Inversion operator(s) #5

FredLunnon opened this issue Sep 16, 2016 · 5 comments

Comments

@FredLunnon
Copy link

The algorithm for general inversion seems to work OK, but the documentation
is seriously confusing, including http://clifford.readthedocs.io/en/latest/ .
From __init__() :

The inverses found are sometimes dependant [sic] on the order of multiplication.

etc. etc.

The only circumstance under which this situation might conceivably arise is
that both are unusably inaccurate, as a consequence of the argument being
approximately singular. Which could in principle be detected by inspecting
the size of the determinant relative to expected rounding error _eps ; a
simpler fix might just inspect __nonzero__( leftLaInv() - rightLaInv() ) .

Ideally I recommend completely expunging
leftInv() , rightInv() , normalInv() ;
and further removing from user documentation
leftLaInv() , rightLaInv() ,
leaving only inv() visible. A warning about potential ill-conditioning for
approximately singular arguments might also be attached.

A fuller discussion of the Clifford inverse has been posted at
https://github.com/FredLunnon/ClifFred/blob/master/inverse.txt

WFL

@arsenovic
Copy link
Member

i think this would make sense. would you consider making a PR for this?

@FredLunnon
Copy link
Author

I'm away from my desk for another 10 days or so. But in the meantime,

Please explain what exactly is a "PR" ?

Also what did you "think would make sense" ? I'm guessing some part of my
earlier proposals, but it's not entirely clear ...

WFL

On Fri, Sep 23, 2016 at 1:01 PM, alex arsenovic notifications@github.com
wrote:

i think this would make sense. would you consider making a PR for this?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/arsenovic/clifford/issues/5#issuecomment-249173805,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG2wLg5kTRXiHNXStUQ7pAb63K7W1gMHks5qs7-IgaJpZM4J_CTL
.

@arsenovic
Copy link
Member

PR is an acronym for Pull Request. its how people contribute code on github.

you clearly have a lot to offer in this field, you should learn git (and python code style) so that people can make use of your efforts!

i think the syntax and usability of clifford is good, especially because its similar to galgebra, but i am not an expert about the internal implementation, so i welcome all improvements.

@FredLunnon
Copy link
Author

OK, message received and understood. I'll take a look on return.
But recall we couldn't get our sites to diff last time ... WFL

On Tue, Sep 27, 2016 at 11:34 PM, Fred Lunnon fred.lunnon@gmail.com wrote:

I'm away from my desk for another 10 days or so. But in the meantime,

Please explain what exactly is a "PR" ?

Also what did you "think would make sense" ? I'm guessing some part of my
earlier proposals, but it's not entirely clear ...

WFL

On Fri, Sep 23, 2016 at 1:01 PM, alex arsenovic notifications@github.com
wrote:

i think this would make sense. would you consider making a PR for this?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/arsenovic/clifford/issues/5#issuecomment-249173805,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG2wLg5kTRXiHNXStUQ7pAb63K7W1gMHks5qs7-IgaJpZM4J_CTL
.

@arsenovic
Copy link
Member

sounds good.

there a tons of people using mac and github, so it should work, and work seamlessly for 95% of what you will need to do. you will want to get your native editor working, @moble might be able to assist you on a mac, if google is failing you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants