-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposed fixes to discrepancy between linear transformation and matrix #469
Comments
Really appreciate it and it looks great to me! Do you plan to submit a PR based on it? Or you can also attach the python files and notebooks and I'll test it locally and try to make a PR. |
utensil, I'm sorry but I don't know what a "PR" is. I'm just an aging mathematics hobbyist who took a couple of edX introductory computer science courses a few years ago, and I'm not familiar with developers' jargon. But I think the contents of the attached zip file should serve. The zip file contains my modification of GAlgebra module lt.py, the unofficial GAlgebra module gprinter.py (Alan Bromborsky, author), and two Jupyter notebooks. The notebooks, when run, test the modifications to lt.py. The file READ_THIS.pdf describes where in lt.py the modifications can be found. |
Closed the issue by accident. See the zip file attached to my post on 2020-10-31 for files which contain my proposed fixes and which test those fixes. |
Oh, sorry for the abbreviation, PR stands for "pull request", which means that you can fork https://github.com/pygae/galgebra and create a few commits with your additional files and/or modifications and create a "ticket" showing the changed contents and the maintainers (@eric-wieser and me) can review, request changes and merge it into GAlgebra eventually. But I can do that with the attached files for you and we can continue the discussions there. Here's an example of a (merged) PR: #468 . You can see the author of the PR is @eric-wieser , who is also a maintainer, it means that he has the permission to directly commit into GAlgebra, but still he created a PR so that we could collaborate in the form of code review and discussion, this is the way of open source world.
|
Utensil Song,
Perhaps in the future I will have sufficient time to learn the procedures
you listed for a "pull request", but right now I am very busy, a state
which will continue for at least the next week.
So I will take you up on your offer to do the necessary actions with the
files I packaged together in *proposed lt.py fixes.zip* (attached to my
post of 2020-10-31).
Thank you,
Greg Grunberg
…On Mon, Nov 2, 2020 at 6:13 PM Utensil Song ***@***.***> wrote:
Oh, sorry for the abbreviation, PR stands for "pull request", which means
that you can fork https://github.com/pygae/galgebra and create a few
commits with your additional files and/or modifications and create a
"ticket" showing the changed contents and the maintainers ***@***.***
<https://github.com/eric-wieser> and me) can review, request changes and
merge it into GAlgebra eventually. But I can do that with the attached
files for you and we can continue the discussions there.
Here's an example of a (merged) PR: #468
<#468> . You can see the author of
the PR is @eric-wieser <https://github.com/eric-wieser> , who is also a
maintainer, it means that he has the permission to directly commit into
GAlgebra, but still he created a PR so that we could collaborate in the
form of code review and discussion, this is the way of open source world.
<https://avatars0.githubusercontent.com/u/33729520?s=400&v=4>
<https://camo.githubusercontent.com/040b5519c6d1891329f5f6d3e511003657131cf2/68747470733a2f2f6769746875622e6769746875626173736574732e636f6d2f66617669636f6e732f66617669636f6e2e737667>
GitHub
*pygae/galgebra <https://github.com/pygae/galgebra>*
Symbolic Geometric Algebra/Calculus package for SymPy 🔮 - pygae/galgebra
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#469 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG2OCIBSPFPGCP6PBLYNR2DSN5DKBANCNFSM4TDBQOLQ>
.
|
Yeah, we'll get to it ASAP (personally I just had a busy week and weekend, so I hadn't got to it). |
In my original posting I included an attachment, Discrepancies between a linear tranformation and its matrix -- proposed fixes.pdf. I wish to take back my suggestion made therein for modifying the string input segment of the
I had determined that the fragment's third line was the problem, but my solution was a kludge. There is a much simpler fix. The fragment's third line invokes
The problem was that the basis expansion of While I do not show it here, testing shows that deletion of the second and third lines of the second code fragment
corrects the problem of incorrect |
Previously I have reported that the matrix of a linear transformation and the action of the transformation on basis vectors disagree. This happens both for specific and generic transformations, although the nature of the disagreement is not the same for the two types of transformation. I have made some slight modifications to lt.py which I believe eliminate the discrepancies. See the attached PDF of a Jupyter notebook.
discrepancies between linear transformation and its matrix -- proposed fixes.pdf
The text was updated successfully, but these errors were encountered: