Remove all dependencies on galgebra.printer #452
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
force-pushed
the
remove-GaPrintable
branch
from
5e55676
to
abda1e6
Compare
|
This pull request introduces 1 alert when merging abda1e6 into eb8ccd2 - view on LGTM.com new alerts:
|
eric-wieser
force-pushed
the
remove-GaPrintable
branch
3 times, most recently
from
0cba561
to
6d8ef28
Compare
This is primarily to make the jupyter notebooks easier to review.
eric-wieser
force-pushed
the
remove-GaPrintable
branch
2 times, most recently
from
5c27543
to
75a63c6
Compare
This means that the custom print customizations are now completely optional. The one behavior change here is that `Mv.__str__` no longer uses our custom plaintext printer by default. That shouldn't be an issue, since `print(Mv)` still does use that printer.
eric-wieser
force-pushed
the
remove-GaPrintable
branch
from
75a63c6
to
b27272d
Compare
eric-wieser
force-pushed
the
remove-GaPrintable
branch
from
595fe37
to
ad3e20d
Compare
eric-wieser
force-pushed
the
remove-GaPrintable
branch
from
ad3e20d
to
f70ad9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that the print customizations are now completely optional, and only take effect if
import galgebra.printeris used. This is a good idea because these customizations may be surprising, as they:printfunctionThis type of surprise should be opted into (by choosing to import this module), not automatic.