Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `__name__ == '__main__'` check from modules #69

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@eric-wieser
Copy link
Contributor

eric-wieser commented Nov 26, 2019

These modules do not make sense to run from the command line, so should not have these lines.

At any rate, these lines do nothing.

These modules do not make sense to run from the command line, so should not have these lines.

At any rate, these lines do nothing.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #69 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage    66.7%   66.63%   -0.07%     
==========================================
  Files           8        8              
  Lines        4890     4880      -10     
==========================================
- Hits         3262     3252      -10     
  Misses       1628     1628
Impacted Files Coverage Δ
galgebra/printer.py 77.29% <ø> (-0.05%) ⬇️
galgebra/lt.py 42.8% <ø> (-0.2%) ⬇️
galgebra/mv.py 61.65% <ø> (-0.05%) ⬇️
galgebra/ga.py 74.68% <ø> (-0.05%) ⬇️
galgebra/metric.py 70.93% <ø> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ae058c...6eba30a. Read the comment docs.

@eric-wieser eric-wieser added this to Low priority in Miscellaneous cleanup Nov 26, 2019
@utensil utensil merged commit 4c7233f into pygae:master Nov 26, 2019
4 of 5 checks passed
4 of 5 checks passed
codecov/project 66.63% (-0.07%) compared to 5ae058c
Details
Travis CI - Pull Request Build Passed
Details
codebeat no reportable quality changes
Details
codecov/patch Coverage not affected when comparing 5ae058c...6eba30a
Details
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
Miscellaneous cleanup automation moved this from Low priority to Closed Nov 26, 2019
@eric-wieser eric-wieser deleted the eric-wieser:remove-__main__-pass branch Nov 26, 2019
@utensil utensil added this to the 0.4.5 milestone Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.