[Scala] Fix type highlighting #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: Scala lexer incorrectly highlights code containing type parameters. This is the patch from pygments#972 (comment), tested by pygments#972 (comment).
Blaisorblade
force-pushed
the
fix-type-highlighting
branch
from
44902e3
to
f965f84
Compare
birkenfeld
approved these changes
Nov 29, 2019
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #1314, fix the following issue:
typeis recognized as a keyword even if inside a word, which isn't correct. To wit, belowtypesis an identifier, not thetypekeyword followed by ans:I expect
forSomeneeds the same treatment, but I haven't tested that.Also, I'm a Scala dev, not a Python one, and I might be doing something silly.