Fix CBM BASIC V2 analyze text logic #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Anteru any update here? |
|
Any update here? |
|
Thanks, I rebased it accordingly. |
Anteru
added
the
changelog-update
Anteru
removed
the
changelog-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes CBM BASIC V2 text analyser to match decimal at the beginning not at anywhere as it was written. Also in the comments you can see
if it starts with a line number.... After fixinganalyse_textfunction it started breaking the testtest_guess_lexer_forthwhich was expecting to getForthLexerbut started gettingCbmBasicV2Lexerso to fix it I changed the weight for ForthLexer to 0.3. All tests are passing.