New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for EOL Python 3.7 #2601
Conversation
@@ -41,7 +40,6 @@ classifiers = [ | |||
] | |||
|
|||
[project.optional-dependencies] | |||
plugins = ["importlib-metadata;python_version<'3.8'"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this should be kept as a dummy, empty plugins
extra, so people can still do pip install pygments[plugins]
?
And then remove it in the next major version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question for @jeanas .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, we should keep it. It hardly has any maintenance cost. Moreover, if we remove it, it becomes impossible for a library to support both Pygments 2.17 with plugins on Python 3.7 and Pygments 2.18 (if it declares pygments
as dependency, it won't get importlib-metadata
on Python 3.7 with Pygments 2.17, and if it declares pygments[plugins]
, pip gives warnings with Pygments 2.18).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-added as a no-op.
Thanks, high time to revisit this (and also update the link in our docs ...) @birkenfeld I just checked: RHEL9 ships with 3.9, Ubuntu 22.04 uses 3.10, and Debian Bookworm is Python 3.11. So we could technically drop 3.7 as per our own guidelines (https://pygments.org/docs/contributing/) -- any concerns? |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Python 3.7 is EOL since 2023-06-27: https://devguide.python.org/versions/
Dropping 3.7 means the https://pypi.org/project/importlib-metadata and
pkg_resources
fallbacks can be removed.