You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have my project with many dependencies, with a tasks.py with invoke tasks in it. I type invoke. I'm using invoke==0.7.0
My expectation
Invoke discovers the tasks in tasks.py.
What actually happens
Invoke walks through my python path and finds a random tasks module in a random package and tries to run it instead and ends up waking a dragon. In another project with an older version of invoke, I know finds a tasks.py for celery.
Reasoning
I would expect the tasks module discovery to find the same module that import tasks finds.
The text was updated successfully, but these errors were encountered:
For some reasoning on the hybrid FS and sys.path approach, see #92 (comment) . Additionally, specific to your issue (which could otherwise be solved by ignoring sys.path) is the fact that folks may want to use a non-local, distributed-via-pip-install module's tasks module instead of one local to themselves. (E.g. inv -c othermodule.tasks.)
The real problem here, though, is that the feature is insufficiently thorough and doesn't ensure your local task module is first in the path in all situations, which leads to the scenario you described.
For example, we ran into the same thing just now here at Pycon sprints, with Invoke itself:
User installs invoke and its dev dependencies including invocations
invocations ends up on sys.pathbeforeinvoke
inv -l now shows invocations' tasks.py's contents (in this case just publish) instead of invoke's own tasks.py (tests, docs etc.)
There was no way for the user to recover from this because it's entirely arbitrary depending on sys.path ordering.
The good news is we just fixed this by always unconditionally putting the local task.py's containing directory first in sys.path, even if it's already in sys.path. This fix is in master now and will be out in the next bugfix release. Please reopen if it doesn't fix for you. Thanks!
The behavior invoke currently has for task module discovery: http://invoke.readthedocs.org/en/0.6.1/concepts/loading.html#task-module-discovery is counter to what I expect.
The Setup
I have my project with many dependencies, with a tasks.py with invoke tasks in it. I type
invoke
. I'm using invoke==0.7.0My expectation
Invoke discovers the tasks in
tasks.py
.What actually happens
Invoke walks through my python path and finds a random tasks module in a random package and tries to run it instead and ends up waking a dragon. In another project with an older version of invoke, I know finds a tasks.py for celery.
Reasoning
I would expect the tasks module discovery to find the same module that
import tasks
finds.The text was updated successfully, but these errors were encountered: