Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying versions for the dependencies #23

Closed
max-hassani opened this issue Oct 18, 2020 · 1 comment
Closed

Specifying versions for the dependencies #23

max-hassani opened this issue Oct 18, 2020 · 1 comment

Comments

@max-hassani
Copy link
Member

Based on the new implementation, all the dependencies are specified by the version. I have a concern and a question about this.
Question: The versions specified are the latest versions. So why shouldn't the docker images be based on the latest versions?
Concern: In case of any update to the dependecies, we need a bot to update the versions and start a pull-request. But then we have to check whether pyiron implementation is compatible with the latest version of the dependencies or not as well.

@jan-janssen
Copy link
Member

jan-janssen commented Oct 19, 2020

  • One of the use cases of Docker is to have full reproducibility, by fixing the version it is easier for others to look up the versions we used. When somebody said he is using the pyiron Docker from Oct 2020 we can easily look up the LAMMPS version he was using.
  • When the next LAMMPS version is no longer compatible to the current pyiron version we make sure our recipe is only updated when we manually update it here. So anybody who might use the Dockerfile to build their own image always gets a working combination of packages.
  • Finally the bot would be a nice extension, but for the moment I guess we are fine updating the images manually. Moreover while building the images I am not even so sure if we need all of them of if a smaller number of images like pyiron/base, pyiron/lammps and pyiron/pyiron is sufficient.
  • I would suggest you do some more testing today and then you can present it in the developer meeting tomorrow to get some more feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants