Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which Docker Images do we need? #25

Closed
jan-janssen opened this issue Oct 19, 2020 · 12 comments · Fixed by #36
Closed

Which Docker Images do we need? #25

jan-janssen opened this issue Oct 19, 2020 · 12 comments · Fixed by #36

Comments

@jan-janssen
Copy link
Member

As already mentioned in #23 (comment) while I previously suggested to have more images I guess it should be fine to reduce the number of images:

  • pyiron/base - which includes - pyiron_base
  • pyiron/lammps - which is based on pyiron/base and additionally includes pyiron, nglview and lammps.
  • pyiron/pyiron - which is based on pyiron/lammps and additionally includes sphinx and gpaw.

In addition we should include Dockerfiles for all images used on the internal server, especially the TEM and DAMASK examples.

@max-hassani
Copy link
Member

max-hassani commented Oct 19, 2020

Yes, may be those three are sufficient. Pyiron/pyiron includes both sphinx and gpaw. So I guess there would be no need to include two additional images. But it depends on the feedback of the users. I am fine with removing the extra images.

@max-hassani
Copy link
Member

I will include an experimental image (including: temmeta, pyprismatic, match-series, and pyxem). But shall it be based on pyiron/base or pyiron/pyiron? In the case of later, the user have full simulation capabilities and experimental post-processing.

@jan-janssen
Copy link
Member Author

Ideally the experimental part would be based on pyiron/base if this is not possible of if you plan to couple DAMASK and LAMMPS then pyiron/lammps should be sufficient. I just want to make sure that the Docker containers we build here are also the ones used in the MPIE Docker server.

@max-hassani
Copy link
Member

Our DAMASK example is coupled with LAMMPS, so pyiron/lammps would be suitable. In the experimental case, we do not have so far a simulation and experimental post-processing coupled. So in this case, pyiron/base would also be sufficient.

@jan-janssen
Copy link
Member Author

Can you add the two Docker images for experimental and DAMASK?

@max-hassani
Copy link
Member

Sure, I am now in a meeting. I will add them just after the meeting.

@max-hassani max-hassani linked a pull request Oct 20, 2020 that will close this issue
@max-hassani max-hassani removed a link to a pull request Oct 20, 2020
@max-hassani max-hassani linked a pull request Oct 21, 2020 that will close this issue
@max-hassani max-hassani removed a link to a pull request Oct 21, 2020
@jan-janssen
Copy link
Member Author

@muh-hassani Can you tell me which of the pyiron Docker Images you are currently using?

@max-hassani
Copy link
Member

max-hassani commented Oct 28, 2020

@jan-janssen I use pyiron/base, pyiron/md and pyiron/damask. But I believe it will be good to have pyiorn/pyiron which included sphinx and GPAW as well.

@max-hassani
Copy link
Member

max-hassani commented Oct 28, 2020

@jan-janssen I also use pyiron/experimental.

@max-hassani
Copy link
Member

@jan-janssen I have started a branch to address this issue.

@jan-janssen jan-janssen linked a pull request Oct 28, 2020 that will close this issue
@max-hassani
Copy link
Member

max-hassani commented Oct 28, 2020

So I will remove the branch that I was working on.

@jan-janssen
Copy link
Member Author

Sorry I did not realise you were working on the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants