Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsable input #41

Merged
merged 6 commits into from
Oct 12, 2022
Merged

Collapsable input #41

merged 6 commits into from
Oct 12, 2022

Conversation

liamhuber
Copy link
Member

@liamhuber liamhuber commented Sep 6, 2022

Todo:

  • dynamically size nodes based on IO
  • hide/show IO ports and center them on the 0th IO port when hidden so connections still look good
  • Add new triangular show/hide buttons
  • Add new node button that shows/hides ports
  • Draw nodes depending on whether they are collapsed or expanded

New behaviour:

  • Nodes can be collapsed or expanded to hide/show IO
  • Nodes with a val no longer display this in their node widget body (it obviously doesn't play well with being collapsable, and the OOP hierarchy was a pain. If it is desperately wanted it can be brought back, but this data is visible in the node interface and/or display panels anyhow)

The json uploaded over at #33 is still a good test set here.

@liamhuber liamhuber changed the title WIP: Collapsable input Collapsable input Sep 7, 2022
@liamhuber liamhuber mentioned this pull request Sep 8, 2022
Base automatically changed from model_viewcontroller_separation to main October 12, 2022 19:22
@liamhuber liamhuber marked this pull request as ready for review October 12, 2022 19:23
@liamhuber liamhuber merged commit de85091 into main Oct 12, 2022
@liamhuber liamhuber deleted the collapsable_input branch October 12, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant