Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying nodes #33

Merged
merged 14 commits into from
Oct 12, 2022
Merged

Displaying nodes #33

merged 14 commits into from
Oct 12, 2022

Conversation

liamhuber
Copy link
Member

@liamhuber liamhuber commented Aug 30, 2022

A new node class that has a "display" button to throw a representation into the gui's out_plot. Gets used across all the pyiron nodes that don't actually control exec flow (e.g. loops, the Lammps job...). So now everyone can "display" their output at the push of a button.

Straight from the docstring:

"""
Has a `Display` button that sends a representation over to the `ryven.ironflow.Gui.GUI.out_plot` window.
Display gets locked until the button is pressed again, or another node gets displayed.
While displayed, display updates automatically on changes to input.
"""

Still needs:

  • Refactoring (Of course there is always more, but this will do for this PR.)
  • Application to the rest of the pyiron nodes

Pre-wired demo attached.

display_proof.json.zip

@liamhuber liamhuber changed the title WIP: Displaying nodes Displaying nodes Sep 2, 2022
@liamhuber liamhuber changed the base branch from main to bugfix_can_deselect_after_node_error September 2, 2022 05:11
@liamhuber liamhuber mentioned this pull request Sep 7, 2022
Base automatically changed from bugfix_can_deselect_after_node_error to main October 12, 2022 19:20
@liamhuber liamhuber marked this pull request as ready for review October 12, 2022 19:20
@liamhuber liamhuber merged commit c8cb5a1 into main Oct 12, 2022
@liamhuber liamhuber deleted the displaying_node_base branch October 12, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant