Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify FileTable and DatabaseAccess #478

Open
pmrv opened this issue Oct 19, 2021 · 1 comment
Open

Unify FileTable and DatabaseAccess #478

pmrv opened this issue Oct 19, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@pmrv
Copy link
Contributor

pmrv commented Oct 19, 2021

Started #336, the general recipe for this to go through the generic interface

https://github.com/pyiron/pyiron_base/blob/master/pyiron_base/database/jobtable.py

and then move each function there to an abstract method in IsDatabase and split the implementation to methods in DatabaseAccess and FileTable. Since the latter is newer, this mostly ends up moving stuff to methods in the former.

@pmrv pmrv added the enhancement New feature or request label Oct 19, 2021
@samwaseda
Copy link
Member

Create one PR per method of jobtable.py, transfer it to filetable.py.

As a preferred alternative to overwriting these methods, SQL alchemy in memory -> Initialization and tests missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants