Issue #691: history and .nocache.html iframes now have style display:…

…none and an id (instead of width/height/border:0px)
pyjs · Feb 23, 2012 · 914564c · 914564c
1 parent 93700ab
commit 914564c
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 11 deletions.
diff --git a/builder/boilerplate/pygwt.js b/builder/boilerplate/pygwt.js
@@ -144,9 +144,8 @@ function __pygwt_injectWebModeFrame(name) {
       var iframe = document.createElement("iframe");
       var selectorURL = parts[0] + parts[1] + ".nocache.html";
       iframe.src = selectorURL;
-      iframe.style.border = '0px';
-      iframe.style.width = '0px';
-      iframe.style.height = '0px';
+      iframe.id = selectorURL;
+      iframe.style.display = 'none';
       if (document.body.firstChild) {
          document.body.insertBefore(iframe, document.body.firstChild);
       } else {

diff --git a/doc/pyjs_site/public/index.html b/doc/pyjs_site/public/index.html
@@ -62,7 +62,7 @@ <h2>Python Javascript Compiler, Desktop Widget Set and RIA Web Framework</h2>
 <a href="./sidebar.html">More</a>
 
 </noscript>
-<iframe id='__pygwt_historyFrame' style='width:0;height:0;border:0'></iframe>
+<iframe id="__pygwt_historyFrame" style="display:none;"></iframe>
 </body>
 </html>
 
diff --git a/pyjs/src/pyjs/browser.py b/pyjs/src/pyjs/browser.py
@@ -52,7 +52,7 @@
 </head>
 <body style="background-color:white">
 <script type="text/javascript" src="%(bootstrap_file)s"></script>
-<iframe id="__pygwt_historyFrame" style="width:0;height:0;border:0"></iframe>
+<iframe id="__pygwt_historyFrame" style="display:none;"></iframe>
 </body>
 </html>
 """

diff --git a/pyjs/src/pyjs/builtin/public/bootstrap.js b/pyjs/src/pyjs/builtin/public/bootstrap.js
@@ -158,9 +158,8 @@ function __pygwt_injectWebModeFrame(name) {
       var iframe = document.createElement("iframe");
       var selectorURL = parts[0] + parts[1] + ".nocache.html";
       iframe.src = selectorURL;
-      iframe.style.border = '0px';
-      iframe.style.width = '0px';
-      iframe.style.height = '0px';
+      iframe.id = selectorURL;
+      iframe.style.display = 'none';
       if (document.body.firstChild) {
          document.body.insertBefore(iframe, document.body.firstChild);
       } else {

diff --git a/pyjs/src/pyjs/builtin/public/bootstrap_progress.js b/pyjs/src/pyjs/builtin/public/bootstrap_progress.js
@@ -158,9 +158,8 @@ function __pygwt_injectWebModeFrame(name) {
       var iframe = document.createElement("iframe");
       var selectorURL = parts[0] + parts[1] + ".nocache.html";
       iframe.src = selectorURL;
-      iframe.style.border = '0px';
-      iframe.style.width = '0px';
-      iframe.style.height = '0px';
+      iframe.id = selectorURL;
+      iframe.style.display = 'none';
       if (document.body.firstChild) {
          document.body.insertBefore(iframe, document.body.firstChild);
       } else {