Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints #58

Closed
brent-stone opened this issue Jan 23, 2022 · 1 comment
Closed

Add type hints #58

brent-stone opened this issue Jan 23, 2022 · 1 comment

Comments

@brent-stone
Copy link

brent-stone commented Jan 23, 2022 •
edited
Loading

Issue

Type hints are needed for downstream projects to use mypy and other automated tooling

Solution

Merge my pull request which includes a decent set of mypy stubs for the package.

Alternatives

Add type hints throughout the package

Context

These stubs satisfied mypy when I installed them into a local /stubs directory for a project that relies on can-isotp.
@pylessard
Copy link
Owner

#57 merged. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pylessard @brent-stone