Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding oauth_token as a valid launch parameter #67

Closed
jichen-amplify opened this issue Aug 31, 2018 · 7 comments · Fixed by #68
Closed

Adding oauth_token as a valid launch parameter #67

jichen-amplify opened this issue Aug 31, 2018 · 7 comments · Fixed by #68

Comments

@jichen-amplify
Copy link
Contributor

Although oauth_token is not required for OAuth's Two-Legged authentication, but it is a valid oauth launch parameter. Apparently, Schoology is mandating it as part of the oauth signature. Could we add 'oauth_token' here as one of the valid launch parameters?

Thanks!

@ryanhiebert
Copy link
Member

Sounds reasonable to me. Would you like to make a pull request?

@jichen-amplify
Copy link
Contributor Author

Sure, I did try to push my branch to the repo first. But looks like I don't have permission to do so.

@ryanhiebert
Copy link
Member

You'll have to make a fork, push your branch to your fork, then open up a pull request from that branch on your fork.

@jichen-amplify
Copy link
Contributor Author

Thanks! PR is open.

@jichen-amplify
Copy link
Contributor Author

@ryanhiebert When can we expect this change to be released to pypi?

@ryanhiebert
Copy link
Member

@jichen-amplify
Copy link
Contributor Author

Awesome! Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants