Added minimal python3.5 test env #3470
Conversation
.travis.yml
Outdated
| @@ -30,6 +30,8 @@ env: | |||
| - FLOATX='float64' TESTCMD="--durations=10 --cov-append pymc3/tests/test_distributions_random.py pymc3/tests/test_shared.py pymc3/tests/test_smc.py pymc3/tests/test_sampling.py pymc3/tests/test_parallel_sampling.py pymc3/tests/test_dist_math.py pymc3/tests/test_distribution_defaults.py pymc3/tests/test_distributions_timeseries.py pymc3/tests/test_random.py" | |||
| - FLOATX='float64' TESTCMD="--durations=10 --cov-append pymc3/tests/test_examples.py pymc3/tests/test_posteriors.py pymc3/tests/test_gp.py" | |||
| - FLOATX='float64' TESTCMD="--durations=10 --cov-append pymc3/tests/test_variational_inference.py pymc3/tests/test_updates.py pymc3/tests/test_shape_handling.py" | |||
| - FLOATX='float64' TESTCMD="--durations=10 --cov-append pymc3/tests/test_variational_inference.py pymc3/tests/test_updates.py pymc3/tests/test_shape_handling.py" | |||
|
I think that this is finally ready for review |
| @@ -46,3 +46,4 @@ fi | |||
| export PATH="$INSTALL_FOLDER/bin:$PATH" | |||
| echo "Adding $INSTALL_FOLDER to PATH. Consider adding it in your .rc file as well." | |||
| conda update -q -y conda | |||
| pip uninstall -y numpy | |||
There was a problem hiding this comment.
I would add a comment that this is installing TravisCI's version of numpy. At a glance its confusing why numpy would be uninstalled
There was a problem hiding this comment.
Thanks Ravin! I'll add it once I get back to my computer in a few hours
| # This may set values for certain nodes in the drawn | ||
| # dictionary, but they don't get added to the givens | ||
| # dictionary. Here, we try to fix that. | ||
| if param in named_nodes_children: |
There was a problem hiding this comment.
From my cursory knowledge this looks good! Out of curiosity though why would the bug only present itself in one version of python?
There was a problem hiding this comment.
I was super puzzled by this too! I finally found that the problem was caused because python 3.6 preserves insertion order for sets and dictionaries, whereas earlier versions did not.
There was a problem hiding this comment.
Ah yes, optional but related. Raymond Hettinger gave an excellent talk on how this came about
https://www.youtube.com/watch?v=npw4s1QTmPg and he was nice enough to answer my question about it on Stackoverflow!
|
A far as I can tell LGTM. I could use help reviewing the draws_values portion |
|
Should we add a python version requirement now? |
|
I think so, but once we do this we should cut a release, not to break existing environments |
If you are going to do that, may I get #3468 merged before the new release? |
After #3465 and taking into account that we want to keep a tight integration with Arviz, I think that we should add a small test environment for python 3.5. I added test_sampling.py and test_model_graph.py because we introduced type hints into sampling.py and model_graph.py, and we need to check if those work well or break python 3.5.