New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added minimal python3.5 test env #3470
Changes from all commits
1ee7a30
7797314
24a7110
4cdce65
7f9b161
c445227
18ddfbc
3719cd4
1c145aa
b9f960a
cee40d7
8db4277
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,3 +46,5 @@ fi | |
export PATH="$INSTALL_FOLDER/bin:$PATH" | ||
echo "Adding $INSTALL_FOLDER to PATH. Consider adding it in your .rc file as well." | ||
conda update -q -y conda | ||
# Uninstalling miniconda's numpy to avoid conflicting versions when creating the test env | ||
pip uninstall -y numpy | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would add a comment that this is installing TravisCI's version of numpy. At a glance its confusing why numpy would be uninstalled There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks Ravin! I'll add it once I get back to my computer in a few hours |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my cursory knowledge this looks good! Out of curiosity though why would the bug only present itself in one version of python?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was super puzzled by this too! I finally found that the problem was caused because python 3.6 preserves insertion order for sets and dictionaries, whereas earlier versions did not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, optional but related. Raymond Hettinger gave an excellent talk on how this came about
https://www.youtube.com/watch?v=npw4s1QTmPg and he was nice enough to answer my question about it on Stackoverflow!
https://stackoverflow.com/questions/44172039/in-raymond-hettingers-pycon-2017-talk-what-is-the-database-representation