Add multiplier for adaptation window sizes #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3705 +/- ##
=======================================
Coverage 89.94% 89.94%
=======================================
Files 134 134
Lines 20430 20430
=======================================
Hits 18375 18375
Misses 2055 2055
|
ColCarroll
reviewed
Dec 4, 2019
junpenglao
reviewed
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from #3596, it would be nice to allow the user to specify the tuning scheduling via a multiplier: each window will be successively larger so that we get better and better estimates for the mass matrix.
To avoid changing any behavior, the default value for this is 1 (although I can imagine that this may be a very bad idea for dense mass matrices? Thoughts?)