Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LocalLinearTrend and Seasonal #322

Closed
kori73 opened this issue Oct 28, 2020 · 1 comment
Closed

Add support for LocalLinearTrend and Seasonal #322

kori73 opened this issue Oct 28, 2020 · 1 comment

Comments

@kori73
Copy link
Contributor

kori73 commented Oct 28, 2020

I would like to work on adding a few time-series distributions starting with LocalLinearTrend and Seasonal.

Looking at the discussions for the AR pull request, I see that you are not currently happy with the way the initial_state_prior for tfp is obtained. Currently, we are passing a MultivariateNormalDiag with initial_state mean and std close to 0.

I have checked how the initial_state_prior is used in the base class (LinearGaussianStateSpaceModel) and it seems that the covariance method needs to be implemented.

Do you have any suggestions on how to proceed?

@fonnesbeck
Copy link
Member

@kori73 Thanks for your interest. The development team has made the decision not to continue with the TFP-based version of PyMC. We will instead be updating the Theano backend to make it compile with JAX and other engines. If you are interested in contributing to PyMC, I'd suggest directing your attention to the PyMC3 repo, as it will continue to the main supported version of PyMC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants