Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create benchmark suite #71

Closed
ricardoV94 opened this issue Dec 1, 2022 · 3 comments
Closed

Create benchmark suite #71

ricardoV94 opened this issue Dec 1, 2022 · 3 comments
Labels

Comments

@ricardoV94
Copy link
Member

Description

Something like https://github.com/numpy/numpy/tree/main/benchmarks could be useful to guide performance-related decisions and alert us to unintended regressions.

@ricardoV94 ricardoV94 added help wanted Extra attention is needed performance labels Dec 1, 2022
@ricardoV94 ricardoV94 pinned this issue Dec 1, 2022
@ricardoV94
Copy link
Member Author

Using pytest-benchmark in #139

There's an option to obtain graphs in a github page of the repo, if anyone is interested in exploring: https://github.com/benchmark-action/github-action-benchmark#charts-on-github-pages-1

@ricardoV94
Copy link
Member Author

We should also add benchmark tests for compilation times, not just runtime. That may be a bit tricky because we need to clear the cache between runs?

@michaelosthege
Copy link
Member

The benchmark suite is there, but it appears to be a bit flaky.
On this recent commit that only affects PyPI package builds, there was a performance alert: a6e7722#commitcomment-98337087

@twiecki twiecki unpinned this issue Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants