Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ FEATURE ] Add a property "have_xem_map" in TV Show object #1262

Closed
fernandog opened this issue Oct 13, 2016 · 7 comments
Closed

[ FEATURE ] Add a property "have_xem_map" in TV Show object #1262

fernandog opened this issue Oct 13, 2016 · 7 comments

Comments

@fernandog
Copy link
Contributor

fernandog commented Oct 13, 2016

Add a property "have_xem_map" in TV Show object so we can avoid to do this check in displayShow to know if that show have xem map or not

get_xem_numbering_for_show returns ALL mappings. But we only need to know if has map or not (True|False)

xem_numbering=get_xem_numbering_for_show(indexerid, indexer),
xem_absolute_numbering=get_xem_absolute_numbering_for_show(indexerid, indexer),

https://github.com/pymedusa/Medusa/blob/develop/medusa/server/web/home/handler.py#L893

in displayShow we add a XEM icon when show has xem map

% if xem_numbering or xem_absolute_numbering:
                <a href="${anon_url('http://thexem.de/search?q=', show.name)}" rel="noreferrer" onclick="window.open(this.href, '_blank'); return false;" title="http://thexem.de/search?q-${show.name}">
                    <img alt="[xem]" height="16" width="16" src="images/xem.png" style="margin-top: -1px; vertical-align:middle;"/>
                </a>
% endif

@medariox @ratoaq2

@fernandog
Copy link
Contributor Author

fernandog commented Oct 13, 2016

i think this may help with subtitle issue so we can use tv_show object to check if has xem map or not

IMO all that scene_numbering could be part of TVE and TVS objects

@fernandog
Copy link
Contributor Author

@p0psicles what do you think?

@p0psicles
Copy link
Contributor

I'm for moving all mako code out of the templates. So if this helps. Why not.

@OmgImAlexis OmgImAlexis changed the title Add a property "have_xem_map" in TV Show object [ FEATURE ] Add a property "have_xem_map" in TV Show object Nov 16, 2016
@fernandog
Copy link
Contributor Author

@xo how did you do with displayShow in vue?

@p0psicles
Copy link
Contributor

@fernandog finished right

@fernandog
Copy link
Contributor Author

No. I didnt add yet. Will do

@labrys
Copy link
Contributor

labrys commented Dec 9, 2017

Closing this as it has been added to the #282 Master Feature List to track all feature requests. Discussion specific to this feature can continue in this thread.

@labrys labrys closed this as completed Dec 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants