Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Episode Select UI change #2186

Closed
wimpyrbx opened this issue Feb 16, 2017 · 2 comments
Closed

Feature Request: Episode Select UI change #2186

wimpyrbx opened this issue Feb 16, 2017 · 2 comments

Comments

@wimpyrbx
Copy link
Contributor

wimpyrbx commented Feb 16, 2017

Would a good idea to "lock in" the episode selector be something like this?

image

Having a <div> to place all the elements (checkboxes, buttons, dropdown) would make it a bit more "visual modular" ? could also be used elsewhere i guess for page-specific options or information.

@Thraxis
Copy link
Contributor

Thraxis commented Feb 16, 2017

That section is already contained in a div:

<div class="row"> <!-- Checkbox filter controls -->
<div class="col-lg-12" id="checkboxControls">
<div class="key">
<div class="row">
<div class="pull-left col-lg-8 col-md-12">
<% total_snatched = ep_counts[Overview.SNATCHED] + ep_counts[Overview.SNATCHED_PROPER] + ep_counts[Overview.SNATCHED_BEST] %>
<label for="wanted"><span class="wanted"><input type="checkbox" id="wanted" checked="checked" /> Wanted: <b>${ep_counts[Overview.WANTED]}</b></span></label>
<label for="qual"><span class="qual"><input type="checkbox" id="qual" checked="checked" /> Allowed: <b>${ep_counts[Overview.QUAL]}</b></span></label>
<label for="good"><span class="good"><input type="checkbox" id="good" checked="checked" /> Preferred: <b>${ep_counts[Overview.GOOD]}</b></span></label>
<label for="skipped"><span class="skipped"><input type="checkbox" id="skipped" checked="checked" /> Skipped: <b>${ep_counts[Overview.SKIPPED]}</b></span></label>
<label for="snatched"><span class="snatched"><input type="checkbox" id="snatched" checked="checked" /> Snatched: <b>${total_snatched}</b></span></label>
<button class="btn btn-xs seriesCheck">Select Filtered Episodes</button>
<button class="btn btn-xs clearAll">Clear All</button>
</div>
<div class="pull-lg-right col-lg-4 col-md-12">
<div class="pull-lg-right">
<select id="statusSelect" class="form-control form-control-inline input-sm">
<option selected value="">Change selected to:</option>
<option value=""">--------------------------------------------</option>
<% availableStatus = [WANTED, SKIPPED, IGNORED, FAILED] %>
% if not app.USE_FAILED_DOWNLOADS:
<% availableStatus.remove(FAILED) %>
% endif
% for cur_status in availableStatus + Quality.DOWNLOADED + Quality.ARCHIVED:
% if cur_status not in [DOWNLOADED, ARCHIVED]:
<option value="${cur_status}">${statusStrings[cur_status]}</option>
% endif
% endfor
</select>
<input type="hidden" id="showID" value="${show.indexerid}" />
<input type="hidden" id="indexer" value="${show.indexer}" />
<input class="btn btn-inline" type="button" id="changeStatus" value="Go" />
</div>
</div>
</div> <!-- end of row -->
</div> <!-- end of key -->
</div> <!-- checkboxControls -->
</div> <!-- end of row -->

It just doesn't have a background, and to have one like you show it would need to be done like the summary background is right now.

@wimpyrbx
Copy link
Contributor Author

ok, might not be worth it, but i feel they are "hanging around" in the design at the moment.
also a side-thought was to include the showheader on the "preview rename" page and have the rename format in that div.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants