Make manual search like the proper search thread

[duramato]

The Proper Search thread unlike any of the "search queue" ones runs along side them.
Making the manual search thread like the proper thread would mean no more queueing which is, imo, a horrible user experience, for an example i've timed mine (starting a manual search with a backlog running and it took ~9 min)
This would mean no killing of threads, no nada, to avoid queuing.
And a 👍 user lol

[fernandog]

need logs

[p0psicles]

@duramato do you suggest we separate the "forced search" from the backlog thread. Making it always run in it's own thread? @labrys what do you think? Is that wise?

[fernandog]

backlog thread? isn't the search thread?

[labrys]

I agree that the manual search should run in it's own thread. There are some potential issues that may need to be addressed, such as the effect on provider sessions, CPU usage on low-powered devices, etc. but I think it would greatly improve user experience.

[p0psicles]

Sure, but then I think we need to agree on pausing or stopping all other search threads when running something from the forcedSearchScheduler thread. Cause then it will be possible to run a daily, backlog, proper and forcedSearch next to each other. Then we're not even talking about the subtitlesFinder thread.

Still om not to sure of this route. Creating a new search thread will kind of invalidate our generic_queue min_priority system. For ex. if we would be able set forced search to highest priority and stop a running backlog or running daily, then the forced search would automatically be run first.

Only real issue we have are the running backlog and daily. As these can run a long time. And the "pause backlog" feature will only work on queued items, not running. That's why I started on the feature to stop a running backlog. If we can do the same for daily, I think we've accomplished our goal.

I also don't agree that we should primarily depend on a forced search, when viewing manual search results. If our daily, backlog and proper searches are properly running and caching results to db, then a forced search should not be required to manual select a result. That a forced search can be triggered from the manual search screen is a "nice to have" IMO.

[p0psicles]

#395