-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds "Manual Snatch" feature #6
Conversation
e906deb
to
3c948fe
Compare
13685d3
to
36b7487
Compare
acbd58c
to
f4f882e
Compare
f4f882e
to
c548c7a
Compare
2d15950
to
3ffdb6c
Compare
xem_absolute_numbering=get_xem_absolute_numbering_for_show(indexerid, indexer), | ||
title=showObj.name, | ||
controller="home", | ||
action="displayShow" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be changed as this isn't the "displayShow" page it's the "manualSearch" page, once that's done we can add the Javascript for it to a new section in core.js
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OmgImAlexis maybe an idea to start with AngularJs. We can do a local installation, but we can also just start with the Google CDN. I was thinking of switching to Rest for the manual search anyway, this way it's easier to update the page while performing a search.
Additional benefit is that we can get some experience using angular, and eventually it will be easier to port. We could just start with a basic app structure and put in some controllers, directives, services, etc. What do you think?
3ffdb6c
to
6cd2562
Compare
2c1e0f1
to
265b961
Compare
e6fe31d
to
f9c334f
Compare
04fe786
to
8f2f8e9
Compare
d1d198b
to
391b06b
Compare
* Fixed bug where force search didn't work anymore Note! Refreshing depends on the timestamps (time field) in cache table for results. These are updated now for every search.
As you've already been redirected when this message is shown.
…ved. * Also fixed endless refresh when no providers enabled.
…the user can't start a second before it's redirected.
696863f
to
8d60b9e
Compare
Adds "Manual Snatch" feature
Good job! Do you want me to test it? |
@adaur feel free! thank for your initiative on this!! |
I'd be glad to. You're welcome, you guys did much more on this than I was able to :p |
TODO:
Improvements:
if search_mode == 'sponly' and (manualSearch is True or manualSelect is True):
if (manualSearch is True or manualSelect is True) and search_mode == 'sponly':
. Also if just checking truthy shorten to(manualSearch or manualSelect)
Show.Sxx.Special.Title & Show.S00Exx
and even more optionally byShow.Title
(Like Sonarr does)DONE:
to here: https://github.com/pyMedusa/SickRage/blob/manual-search/sickbeard/search.py#L94
Before Snatch
After Snatch