Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First go at moving to xo #858

Merged
merged 2 commits into from
Aug 10, 2016
Merged

First go at moving to xo #858

merged 2 commits into from
Aug 10, 2016

Conversation

OmgImAlexis
Copy link
Collaborator

@OmgImAlexis OmgImAlexis commented Aug 7, 2016

@p0psicles @Thraxis

This uses https://github.com/sindresorhus/xo and https://github.com/sindresorhus/atom-linter-xo

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read contribution guide

@coveralls
Copy link

Coverage Status

Coverage remained the same at 28.881% when pulling 76368186ad8f081cc865d6b2f325f913a1183e58 on jshint_to_xo into f90f3d3 on develop.

@OmgImAlexis OmgImAlexis force-pushed the jshint_to_xo branch 2 times, most recently from d3794e9 to 09205b3 Compare August 7, 2016 09:02
@coveralls
Copy link

coveralls commented Aug 7, 2016

Coverage Status

Coverage decreased (-0.007%) to 28.874% when pulling 09205b3ee88253980af3bc7234bf06527b1ee498 on jshint_to_xo into f90f3d3 on develop.

@coveralls
Copy link

coveralls commented Aug 7, 2016

Coverage Status

Coverage remained the same at 28.881% when pulling 09205b3ee88253980af3bc7234bf06527b1ee498 on jshint_to_xo into f90f3d3 on develop.

@coveralls
Copy link

coveralls commented Aug 7, 2016

Coverage Status

Coverage decreased (-0.007%) to 28.874% when pulling 09205b3ee88253980af3bc7234bf06527b1ee498 on jshint_to_xo into f90f3d3 on develop.

$('#emby_apikey').addClass('warning');
} else {
$('#emby_apikey').removeClass('warning');
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these can now be changed to use the jQuery function I added.

 if (!emby.host) {
     $('#emby_host').addClass('warning');
 } else {       
    $('#emby_host').removeClass('warning');     
 }
$('#emby_host').addRemoveWarningClass(emby.host);

@medariox medariox added this to the 0.1.4 milestone Aug 10, 2016
@medariox
Copy link
Contributor

So I have been testing this for a few hours, trying out everything I could etc. My JS knowledge is fairly limited, but everything seems to be running just fine so far.

What I noticed:

@OmgImAlexis
Copy link
Collaborator Author

OmgImAlexis commented Aug 10, 2016

The issue about the wizard is fine since it's defined in the vender.min.js file.

It's already passed travis so that's fine for now. The next PR I'm pushing has most of the other fixes but I didn't want to add onto an already extremely large PR.

@medariox
Copy link
Contributor

medariox commented Aug 10, 2016

Approved

Sounds good!

Approved with PullApprove

@fernandog
Copy link
Contributor

@OmgImAlexis concluded?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants