-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First go at moving to xo #858
Conversation
64c3d20
to
7636818
Compare
Coverage remained the same at 28.881% when pulling 76368186ad8f081cc865d6b2f325f913a1183e58 on jshint_to_xo into f90f3d3 on develop. |
d3794e9
to
09205b3
Compare
Coverage decreased (-0.007%) to 28.874% when pulling 09205b3ee88253980af3bc7234bf06527b1ee498 on jshint_to_xo into f90f3d3 on develop. |
Coverage remained the same at 28.881% when pulling 09205b3ee88253980af3bc7234bf06527b1ee498 on jshint_to_xo into f90f3d3 on develop. |
Coverage decreased (-0.007%) to 28.874% when pulling 09205b3ee88253980af3bc7234bf06527b1ee498 on jshint_to_xo into f90f3d3 on develop. |
$('#emby_apikey').addClass('warning'); | ||
} else { | ||
$('#emby_apikey').removeClass('warning'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these can now be changed to use the jQuery function I added.
if (!emby.host) {
$('#emby_host').addClass('warning');
} else {
$('#emby_host').removeClass('warning');
}
$('#emby_host').addRemoveWarningClass(emby.host);
So I have been testing this for a few hours, trying out everything I could etc. My JS knowledge is fairly limited, but everything seems to be running just fine so far. What I noticed:
|
The issue about the wizard is fine since it's defined in the It's already passed travis so that's fine for now. The next PR I'm pushing has most of the other fixes but I didn't want to add onto an already extremely large PR. |
@OmgImAlexis concluded? |
7dba227
to
117ee1c
Compare
@p0psicles @Thraxis
This uses https://github.com/sindresorhus/xo and https://github.com/sindresorhus/atom-linter-xo