Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in is_significant function #88

Closed
dantetemplar opened this issue Jul 28, 2024 · 4 comments
Closed

Bug in is_significant function #88

dantetemplar opened this issue Jul 28, 2024 · 4 comments

Comments

@dantetemplar
Copy link

dantetemplar commented Jul 28, 2024

In pymupdf_rag.py:196 "q" stands for Quad type but it should be "qu" I guess. That leads to runtime error.

elif itm[0] == "q": # quad

@dantetemplar dantetemplar changed the title Bug Bug in is_significant function Jul 28, 2024
@Stephen-S-H
Copy link

Stephen-S-H commented Jul 29, 2024

I can confirm this error, and that changing this line to
elif itm[0] == "qu":
does fix the issue. I've changed it to this just to be safe for the time being:
elif itm[0] in ("q", "qu"): # quad

@bhashithe-air
Copy link

Thanks both, yes changing to 'qu' worked! Can send a PR if needed.

@bhashithe-air
Copy link

@dantetemplar #93 seems to do the same fix, so i closed mine.

@JorjMcKie
Copy link
Contributor

Fixed in v0.0.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants