Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rfmon support rebased #67

Merged
merged 2 commits into from
Apr 27, 2018
Merged

Rfmon support rebased #67

merged 2 commits into from
Apr 27, 2018

Conversation

hellais
Copy link
Member

@hellais hellais commented Feb 22, 2018

This is a rebase of this branch: #32

cc @gpotter2

ograff and others added 2 commits February 22, 2018 13:50
@ograff @hellais
Support create / activate paradigm for pcap objects, and RFMON
409626b 
Use pcap_create, then set options, and pcap_activate when creating pcap
objects

Support setting rfmon option of pcap creation

Fixes #31
@hellais
re-add pcap_open_live to pcap.pyx
5de8fac
@hellais hellais mentioned this pull request Feb 22, 2018
Closed
@hellais hellais changed the title Rfmon support rebase Rfmon support rebased Feb 22, 2018
@gpotter2
Copy link

Thanks ! I will investigate so see if this works

@gpotter2 gpotter2 mentioned this pull request Feb 22, 2018
Closed
@gpotter2
Copy link

Merge ?

This was referenced Apr 18, 2018
Merged
Closed
@hellais
Copy link
Member Author

hellais commented Apr 18, 2018

I actually haven't had a chance to test this extensively, but if @gpotter2 you say it's working well for you I can proceed with merging it.

@gpotter2
Copy link

To be fair, I couldn't test it either... I don't currently have access to a computer supporting this :/ Will see If someone can do it for me

@gpotter2
Copy link

gpotter2 commented Apr 23, 2018 •
edited
Loading

One user reported that it's working !
secdev/scapy#1350 (comment)
Should be mergeable. After that, it would be great to have a release so we can report the required version

@ograff
Copy link
Contributor

ograff commented Apr 23, 2018

If more directed testing is needed I'll have time after Thursday

@gpotter2
Copy link

gpotter2 commented Apr 27, 2018 •
edited
Loading

@hellais This is mergeable, and working ! Please release it asap, we are waiting for it

@hellais
Copy link
Member Author

hellais commented Apr 27, 2018

@gpotter2 thanks for the input on this. I am going to merge this into master. Do some smoke testing to ensure nothing breaks for the current use cases and then cut a new release.

@hellais hellais merged commit 52afa7c into master Apr 27, 2018
@gpotter2
Copy link

Thank you a lot !!

@hellais hellais deleted the rfmon_support_rebase branch April 28, 2018 11:13
@hellais
Copy link
Member Author

hellais commented Apr 28, 2018

@gpotter2 I just cut 1.2.1 and uploaded it to pypi. Enjoy!

@gpotter2
Copy link

Thanks !!

@hellais hellais mentioned this pull request Dec 11, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hellais @gpotter2 @ograff