Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic on bindings mismatch to manifest-dir #1632

Closed
1 of 2 tasks
joshua-auchincloss opened this issue May 26, 2023 · 1 comment · Fixed by #1635
Closed
1 of 2 tasks

panic on bindings mismatch to manifest-dir #1632

joshua-auchincloss opened this issue May 26, 2023 · 1 comment · Fixed by #1635
Labels
bug Something isn't working

Comments

@joshua-auchincloss
Copy link

Bug Description

maturin panics and does not recognize conditions where:

  • pyproject.toml is used
  • bindings are set
  • manifest-path is set
  • bindings dir does not exist in manifest

Your maturin version (maturin --version)

1.0.0

Your Python version (python -V)

3.10.2

Your pip version (pip -V)

21.2.4

What bindings you're using

pyo3

Does cargo build work?

  • Yes, it works

If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)?

  • Yes

Steps to Reproduce

  1. create src structure project
-> src
---> rust_a
------> Cargo.toml
------> src
--->rust_b
------> Cargo.toml
------> src
-> py_lib
  1. in pyproject.toml
[tool.maturin]
python-source = "py_lib"
bindings = "bin" # does not exist
manifest-path = "src/rust_a/Cargo.toml"
module-name = "rust_a"
strip = true
exclude = [

]
  1. maturin build
@joshua-auchincloss joshua-auchincloss added the bug Something isn't working label May 26, 2023
@messense
Copy link
Member

Sorry I don't quite understand what you mean by bindings = "bin" # does not exist, can you provide a git repository for repro?

@messense messense added the question Further information is requested label May 27, 2023
@messense messense removed the question Further information is requested label May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants